[pull] main from unicode-org:main #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc 5.5 on Solaris refuses to recognise pow(int, int32_t)
Bumps xercesImpl from 2.12.0 to 2.12.2. --- updated-dependencies: - dependency-name: xerces:xercesImpl dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Remove the functions UVector::addElementX() and UVector::ensureCapacityX() that were temporarily added to aid in the cleaning up of UVector's out-of-memory error handling.
1. \u30fc doesn't belong to Hira, Kana nor Han. Add it into CJK dictionary 2. Include fullwidth char into ALPlus
…n of
adding performance tests to ICU CI.
- test/perf/Makefile.in:
adds strsrchperf to list of subdirs.
changes target 'all' to compile everything in the standard way.
- test/perf/ustrperf/Makefile.in: changes target executable from stringperf to
ustrperf (i.e. name of directory) to allow uniform handling with other
perf tests in GHA CI rules.
- tools/ctestfw/uperf.cpp: changes output to ndjson format for processing with
GHA Benchmark. Keep the previous output, which gets processed by the Perl
scripts, when executed in 'verbose' mode. Backward compatibility,
in case someone still wants to use the Perl scripts for the time being.
May get cleaned up later.
Also remove a few non-essential output lines that would interfer with
GHA Benchmark.
processing
ICUNotifier::notifyChanged() was using the thread-unsafe double-checked lock idiom. Replace it with use of the mutex only.
…testInsertOverflow crash
This variable was flagged by a chromium check that looks for variables named like constants that end up in the `.data` ELF section (rather than in `.rodata`).
…ed by GitHub Action. This includes introducing a new flag (-a) to indicate invocation from command line/GHA shell, moving elements of the workflow from Perl into the Java framework (calculation of iteration numbers), and generating NDJSON output for GitHub Benchmark processing. Backward compatibility with the Perl script invocation has been preserved. ICU-22036 Adds a comment clarifying the reason why NDJSON output is generated.
…ing the first currency in the list now select the first legal tender currency in the list. Or the first currency if the list has no legal tender currencies (which is the previous behaviour). ICU-21997 Removed an overlooked earlier unit test attempt. ICU-21997 Shields C++ unit test from compilation when configuration flag UCONFIG_NO_FORMATTING is set.
…ration workflow. Also fixes a tiny oversight in the ICU4J performance framework.
…of the ICU4J performance tests.
This patch also includes marking `=delete` on specific `normal` member functions, as opposed to compiler generated functions, based on the description of such functions' surrounding comments.
This helps to avoid missleading error message:
```
./source/configure: line 7981: syntax error near unexpected token 'newline'
./source/configure: line 7981: 'AX_CHECK_COMPILE_FLAG('
```
… subtag (when it has one) when determining the hour cycle.
… add a few small changes to support running ICU unit tests in Xcode.
…at runs as part of a high concurrency performance test setup. This will disperse commits of performance test results into the data branch over a wider time frame and drastically reduces the chance of data uploads failing after ten unsuccesful commit attempts. Test runs showed a huge drop in failed commits/retry, from a high of 113 without wait down to only 4 with the extra wait. ICU-22075 Add comment explaining the rationale of the random sleep period prior to test execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )