Add support for removeFingerprintOnSuccess config property#27
Closed
jjrodrig wants to merge 2 commits intotus:masterfrom
Closed
Add support for removeFingerprintOnSuccess config property#27jjrodrig wants to merge 2 commits intotus:masterfrom
jjrodrig wants to merge 2 commits intotus:masterfrom
Conversation
Member
|
Thank you for this PR and your patience. I had a thorough look at your patch and there are two topic I would like to talk about:
|
jjrodrig
commented
Jun 3, 2019
jjrodrig
commented
Jun 3, 2019
Author
|
Thanks @Acconut |
Acconut
added a commit
that referenced
this pull request
Jun 13, 2019
See #27 Squashed commit of the following: commit b664f5b11b406d1ecf9b8fb5e2286de15641cc15 Author: Marius <maerious@gmail.com> Date: Thu Jun 13 12:16:27 2019 +0200 Move line endings back to Unix's LF commit b5807b8 Author: Juan Jose Rodriguez <jj.rodriguez@lks.es> Date: Tue Jun 4 17:16:59 2019 +0200 Change uploadFinished visibility to protected commit ebb5eab Author: Juan Jose Rodriguez <jj.rodriguez@lks.es> Date: Tue May 21 14:41:37 2019 +0200 #26 Add support for removeFingerprintOnSuccess config property
Member
|
Thank you for the changes. I fixed a few trailing whitespace issues and also converted your Windows CRLF line endings back to Unix's LF. Merged in 003ff8a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds removeFingerprintOnSuccess config property to TusClient that allows to define whether the upload URL should be removed from the URL store after a successful upload.
This behaviour is disabled by default and should be enabled by calling:
Closes #26 issue