Modify upload pausing#42
Merged
Acconut merged 5 commits intotus:masterfrom Aug 10, 2021
cdr-chakotay:master
Merged
Conversation
Make uploads pausable without closing file input Streams
Add a pause functionality, which doesn't close the InputStream
Acconut
requested changes
Jul 26, 2021
Member
Acconut
left a comment
Acconut
left a comment
There was a problem hiding this comment.
Nice work! We might have hit a road block here, which could complicate matter a bit :|
cdr-chakotay
commented
Aug 5, 2021
Contributor
Author
cdr-chakotay
left a comment
cdr-chakotay
left a comment
There was a problem hiding this comment.
Integrated those changes in a slightly different manner.
Acconut
approved these changes
Aug 10, 2021
Member
Acconut
left a comment
Acconut
left a comment
There was a problem hiding this comment.
Made a few formatting fixes on my own and looks ready now! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overloads the TusUploader#finish() method in order to provide a pausable upload, which doesn't close the underlying InputStream.