Conversation
pdenooijer
commented
Mar 7, 2023
LaravZ
reviewed
Mar 8, 2023
Acconut
requested changes
Mar 8, 2023
Member
Acconut
left a comment
Acconut
left a comment
There was a problem hiding this comment.
Thank you for this PR! I have a few concerns but overall this goes in a great direction. Please also avoid force pushing, which makes reviews hard.
Contributor
Author
I added a new commit this time, that should fix all comments. On a side note, on a force push you could use the compare functionality for a review 🙂. |
Contributor
Author
|
@Acconut I found a small inconsistency in the readme, should now be ready for review round two! |
Acconut
requested changes
Mar 16, 2023
Member
Acconut
left a comment
Acconut
left a comment
There was a problem hiding this comment.
Thank you very much. This looks nearly finished. Just two minor touches are left.
By default the NO_PROXY proxy is used which is the same as a direct request. Adding the possibility to override the proxy with an own instance pointing to the proxy to use when uploading.
Contributor
Author
|
Awesome! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default no proxy is used, which will look up if it should use a proxy or a direct request. Adding the possibility to add a proxy instance pointing to the proxy to use when uploading.
This will fix #52.