-
Notifications
You must be signed in to change notification settings - Fork 217
Fix creation-defer-length extension for all stores #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd rename |
dfeede8 to
be44f6f
Compare
|
This PR is almost complete. All that is needed is to implement Any idea why status 412 is sent when upload-length does not match? I think this error code is not appropriate and 400 would be much better. @Murderlon sorry for taking over this PR without consulting you. 😊 |
be44f6f to
3222647
Compare
Yes we can change that, tus also does this: |
|
I'll take a look at the S3 and GCS ones |
|
Thanks for improving this too. I added it to S3 and GCS too. Two things:
EDIT: I disabled parallel jobs in 43c45b7, which seems to help with rate limiting. Regardless, this PR should be ready |
|
Merged it as I have more time for tus-node-server and I want to run a TS migration script without too many conflicts. Review still welcome, I can make the changes in a separate PR. I'll wait another day with releasing this in case you have feedback. |
|
I have no further comments. I think this can be released, 0.8.0 would be appropriate as there are some breaking changes. |
Supersedes #283