Skip to content

Conversation

@bypie5
Copy link
Contributor

@bypie5 bypie5 commented Oct 12, 2022

Server owners to configure expiration time with expirationPeriodMintues property in FileStoreOptions. Then, the server owner can periodically invoke Server::cleanUpExpiredUploads() to remove uploads that are both expired AND incomplete.

Server owners to configure expiration time with expirationPeriodMintues property in FileStoreOptions. Then, the server owner can periodically invoke Server::cleanUpExpiredUploads() to remove uploads that are both expired AND imcomplete.
@bypie5
Copy link
Contributor Author

bypie5 commented Oct 12, 2022

Hello, I noticed that this feature was planned in this issue, but it looks the extension was never added. Here's an implementation of the expiration extension. Please let me know if you'd like me to address anything related to the PR.

@Murderlon
Copy link
Member

Hi, thanks for taking the time to contribute! I just switched the whole project to TS (#308) for #309. This means merging this into master will create very hard to resolve conflicts. I think it's best to work on this again once I created and merged a PR from the proper-types branch and then change the base of this PR to the 1.x branch.

@bypie5
Copy link
Contributor Author

bypie5 commented Oct 13, 2022

Hi, thanks for taking the time to contribute! I just switched the whole project to TS (#308) for #309. This means merging this into master will create very hard to resolve conflicts. I think it's best to work on this again once I created and merged a PR from the proper-types branch and then change the base of this PR to the 1.x branch.

Thanks for the information! I'll close this PR for now and keep an eye out for that PR for proper-types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants