Allow async execution and cancelling - Session.signal Session.execute_async#12
Open
dbernheisel wants to merge 1 commit intomainfrom
Open
Allow async execution and cancelling - Session.signal Session.execute_async#12dbernheisel wants to merge 1 commit intomainfrom
Session.signal Session.execute_async#12dbernheisel wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on #11 but with a different API and closer to real bash mannerisms.
Bash.Session.signal(..., signal)to give more control on how to kill the bash session. If passing in the session, it's going to signal to the current execution. If passing in a reference, it will cancel that execution. If it hasn't executed yet (eg, there are multiple chainedexecute_asyncand it hasn't gotten there yet, it will pop from the queue and have a synthetic exit.Bash.execute_asyncto return a set of references for tracking execution, before it would simply return:okbut now it's{:ok, info}. This allows the user to cancel that execution.Bash.Session.execute_asyncon a session will queue up the executions serially. This somewhat acts like merging Bash scripts, but they're chunked and individually await-able.Bash.executenow usesexecute_asyncbut awaits upon it.@lostbean would you mind reviewing and testing this to see if this meets your needs?