Fix test suite for hasql>=1.7 #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfarrell
force-pushed
the
gtf/fix-hasql-1.7-support
branch
from
8b9a1f8 to
4904721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of hasql-migration would build on later versions of hasql, but their test suites would not, which broke the version for nixpkgs.
This updates the dependencies to
hasql>=1.7, slightly modified the test setup by being more specific about the database connection, and fixes the imports in the tests, both for defining connections and importing errors.I tried to maintain support for hasql<1.7 with
CPPmacros, but they wouldn't work for me and I didn't have time to investigate why.