Change first-child to first-of-type in btn-group#175
Closed
mermop wants to merge 1 commit intotwbs:masterfrom
mermop:patch-1
Closed
Change first-child to first-of-type in btn-group#175mermop wants to merge 1 commit intotwbs:masterfrom mermop:patch-1
mermop wants to merge 1 commit intotwbs:masterfrom
mermop:patch-1
Conversation
Author
|
Realised this is the wrong place to open this PR - I put it in the bootstrap repo instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello friends! Long-time listener, first-time caller 📞
This PR changes the selector for resetting rounded corners of
btnelements inbtn-groupsfromfirst-childtofirst-of-typeto accommodate hidden inputs in sets of checkboxes or radio buttons.The Rails collection_check_box or Simple Form or Formtastic all add a hidden input either at the beginning or end of a collection of check boxes or radio buttons. This makes implementing groups of checkboxes or radio buttons as per the documentation either painful or slightly ugly.
Hope this is the right place to put this PR!
Markup using Rails collection_check_boxes
Screenshot using first-child/last-child
Screenshot using first-of-type/last-of-type