Why keep non-tether css?

[IdanCo]

Both tooltip and popover keep maintaining a .tooltip-[direction] and .popover-[direction] classes, in addition to the tether classes:

// from scss/_tooltip.scss
  &.tooltip-top,
  &.bs-tether-element-attached-bottom {
    padding: $tooltip-arrow-width 0;
    margin-top: -$tooltip-margin;

I admit these non-tether classes are prettier than the tether ones, but they increase the minified bootstrap.css by almost 1k (see non-minified compare), and I can't see the purpose they fulfill. Perhaps it's a relic from the pre-tether era.

Worth mentioning that these classes are currently used in the docs in the static demo section. Even so, they can be easily replaced by the tether classes:

--- docs/components/tooltips.md	(date 1492073561000)
+++ docs/components/tooltips.md	(revision )
@@ -50,7 +50,7 @@

-  <div class="tooltip tooltip-top" role="tooltip">
+  <div class="tooltip bs-tether-element-attached-bottom" role="tooltip">
     <div class="tooltip-inner">
       Tooltip on the top
     </div>

Is it PR worthy? Notice that this will be a breaking change (in case someone relied on these classes), so it might be worth considering before the beta release.

[pkozlowski-opensource]

Just one thing to consider: we (https://ng-bootstrap.github.io) are building Angular-specific widgets based on Bootstrap CSS and we do not use tether for positioning. So the proposed change would be indeed a breaking change.

But I feel like the proposed change would impact anyone just writing CSS (without using JS to open tooltips / popovers) - not only a breaking change but also a more verbose alternative.

More importantly I feel like the proposed change would "leak" internal implementation details of Bootstrap (3rd party lib being used). Since I think I've seen some chatter about replacing tether with sth else so the mentioned "leak of impl details" would play a role here.

[pkozlowski-opensource]

Bum, speaking of replacing tether: #22444 :-)

[IdanCo]

good points @pkozlowski-opensource , when you put it like that it's worth the extra k.

ha! bum indeed, bum indeed...

[mdo]

We'll leave them as-is until we determine what we're doing with the Tether replacement.