replace reboot/normalize monospace hack with monospace system font stack

[client9]

There are two stanzas (selectors) for code, kbd, pre, samp in the main bootstrap distribution

The first in reboot:

code, kbd, pre, samp {
  font-family: monospace,monospace;
  font-size: 1em;
}

And then later in bootstrap:

code, kbd, pre, samp {
  font-family: SFMono-Regular,Menlo,Monaco,Consolas,"Liberation Mono","Courier New",monospace;
}

The proposal would be to move the system monospace font stack into reboot and get rid of the monospace, monospace hack (more details of which can be found here: necolas/normalize.css#695 ). I think this would make reboot more consistent (since sans-serif font uses system stack), be more clear, and make bootstrap smaller.

thoughts?

regards,

n

[XhmikosR]

/CC @mdo @andresgalante

[mdo]

I'm down with that.

[XhmikosR]

@client9: PRs welcome :)

[client9]

@XhmikosR ... acknowledged, and in queue (along with the other 2 tickets I filed). However, my wife opened a PR on a new baby in 6 days, so I might be busy. If anyone else is reading this and wants to do it first, please go ahead. Otherwise I'll get to it when I can (they are trivial changes, but I don't have a nodejs stack set up for builds, etc).

[XhmikosR]

Hehe, no worries. Good luck with that! I just always try to bring more people to contribute instead of only asking. Someone will take care of it, even I might, if I find some time.

…

On Tue, Apr 10, 2018, 23:27 Nick Galbreath ***@***.***> wrote: @XhmikosR <https://github.com/XhmikosR> ... acknowledged, and in queue (along with the other 2 tickets I filed). However, my wife opened a PR on a new baby in 6 days, so I might be busy. If anyone else is reading this and wants to do it first, please go ahead. Otherwise I'll get to it when I can (they are trivial changes, but I don't have a nodejs stack set up for builds, etc). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26228 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtWa7gT-q6mzphmIc7XeGEnROuG9-ks5tnRVYgaJpZM4TNAUw> .

[client9]

Pull request is in! #26257

Getting a work environment was quite challenging. I post in another ticket my solution. The good news I can bang out the other changes very easily now.

Comments welcome.

[derekbtw]

Hey just so you guys know, the documentation isn't right.
It's not .font-monospace but rather .text-monospace
And sorry but I'm kinda lazy so I'd rather not go through the pull request process for this.. 😅

[XhmikosR]

@derekbtw: unrelated to this and already fixed.