Switch button firing change event 3 times in BS 4.5.0

[dkwebtec]

I have tried this issue under version 4.5.0 and the method seems working but the change event is fired 3 times on each button click

https://codepen.io/DK568/pen/MWYxWMO

try to click the button

Originally posted by @dkwebtec in #30077 (comment)

[XhmikosR]

/CC @Lausselloic since it's your patch :)

[XhmikosR]

@Lausselloic is this the same issue as #30849?

[Lausselloic]

it's not the same issue but yes event is propagate to childrens inside the label. I could give a try to handle that

[XhmikosR]

@Lausselloic please do so, thanks!

[mdo]

#31000 targets v4-dev, but what about this change in v5?

[XhmikosR]

@Lausselloic can you confirm please that this issue does not affect v5? I believe we removed most of the Button JS so this doesn't seem to apply to v5.

[Lausselloic]

Sorry for the late reply, that doesn't affect v5 at time, there's a need to backport @patrickhlauke fixes (#28952 and #28834) those accessibility fixes are not present's in v5 I will give a try to port it.

[UPDATE]
But following @MartijnCuppens commit (1a0a085) looks like there's no more js needed in v5.

Looks like V5 version is usable with keyboard successfuly https://v5.getbootstrap.com/docs/5.0/forms/checks-radios/#toggle-buttons and using label with for attribute instead of input inside the label will prevent multiple events

[MartijnCuppens]

Yup, the v5 implementation is just superb 😛

[XhmikosR]

Fixed by #31000, thanks @Lausselloic!