Skip to content

Docs - Getting started: refactor 'Customizing Bootstrap'#10459

Merged
mdo merged 5 commits intotwbs:masterfrom
StevenBlack:GSEdits7
Sep 6, 2013
Merged

Docs - Getting started: refactor 'Customizing Bootstrap'#10459
mdo merged 5 commits intotwbs:masterfrom
StevenBlack:GSEdits7

Conversation

@StevenBlack
Copy link
Copy Markdown
Contributor

There's still much to add to the "Customizing bootstrap" section. This is just a starter: normalizing what's already there for readability, keeping non-native speakers in-mind. In some places I added minor clarifications.

Notable changes here:

  • Shrank and normalized section whitespace breaks. It's three linefeeds everywhere now. Not sure if there's a standard for this, but this looks fine to my eye.
  • Most changes make shorter, less wordy sentences. There are exceptions where I felt clarity trumped brevity.

Looking forward, we should distinguish between 'Customizing Bootstrap'" (modify and extend as in this section), and "Customize and download" (theming and cherry-picking components and features with the wizard.)

Comment thread getting-started.html Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"include" would make more sense than "invoke", IMO. CSS isn't a programming language per se.

Comment thread getting-started.html Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and L53 shouldn't include a .

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Comment thread getting-started.html Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the dot here too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (sorry I missed that. Found another actually.)

@Merg1255
Copy link
Copy Markdown

Merg1255 commented Sep 6, 2013

Providing a screenshot of the final product would be nice.

@StevenBlack
Copy link
Copy Markdown
Contributor Author

Here you go, well, 90% of it. My capture tool doesn't scroll from an arbitrary point.

@woshicixide
Copy link
Copy Markdown

good

@Merg1255
Copy link
Copy Markdown

Merg1255 commented Sep 6, 2013

It looks nice.

@StevenBlack
Copy link
Copy Markdown
Contributor Author

  • Ping *

I'd like to further develop this section, building upon its latest state, in a new branch.

In other words, basic cleanup (this PR) first, then its extension with more advanced workflows, which are surely a separate discussion from this first-pass cleanup.

@mdo mdo mentioned this pull request Sep 6, 2013
@mdo mdo merged commit 0067399 into twbs:master Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants