Remove "Unicode space" from @breadcrumb-separator#10467
Closed
sirreal wants to merge 1 commit intotwbs:masterfrom
sirreal:master
Closed
Remove "Unicode space" from @breadcrumb-separator#10467sirreal wants to merge 1 commit intotwbs:masterfrom sirreal:master
sirreal wants to merge 1 commit intotwbs:masterfrom
sirreal:master
Conversation
The correct spacing around "@breadcrumb-separator" is achieved by the padding on the li:before content (0 5px). Adding a space to the content was causing irregular alignment in the breadcrumbs. Tested: OSX - Chrome / Firefox
Member
|
Looks fine to me in Chrome—the space is there, per the comment, to account for white-space behavior with |
Author
Author
|
I see the problem. Bootstrap expects space between the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The correct spacing around
@breadcrumb-separatoris achieved byli:before {padding: 0 5px;}.Adding a space after the
@breadcrumb-separatorwas causing the left side to be 5px and the right to be 5px + " ", making one side larger than the other.Tested: OSX - Chrome / Firefox