Skip to content

Account for badges in buttons#11268

Closed
Livinius wants to merge 2 commits intotwbs:masterfrom
Livinius:master
Closed

Account for badges in buttons#11268
Livinius wants to merge 2 commits intotwbs:masterfrom
Livinius:master

Conversation

@Livinius
Copy link

Suggestion for making badges in buttons look better.
image

PS. No idea where the select came from, just did a "grunt dist"

less/badges.less Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use nesting so that .badge doesn't have to be repeated.

@Livinius
Copy link
Author

Thanks for the tip, I've updated the less to include nesting

@cvrebert
Copy link
Collaborator

cvrebert commented Nov 6, 2013

X-Ref: #11217

@mdo mdo mentioned this pull request Dec 1, 2013
@mdo
Copy link
Member

mdo commented Dec 1, 2013

Fixed manually with an update to the button variant mixin. Thanks!

@mdo mdo closed this Dec 1, 2013
mdo added a commit that referenced this pull request Dec 1, 2013
…d to text color and text color to background
@etishor
Copy link

etishor commented Dec 6, 2013

There appears to be an issue with a badge on a btn btn-default where the badge background color is white and the color is also white.

Ex: http://plnkr.co/edit/NVcsmFOFRKRIWsPsoKBc?p=preview

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 6, 2013

@etishor Please open a new bug.

stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
…g background to text color and text color to background
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
…g background to text color and text color to background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants