unnecessary prefixes removed for gradients#11537
unnecessary prefixes removed for gradients#11537awebdeveloper wants to merge 7 commits intotwbs:masterfrom
Conversation
|
What did you make with commit history? This looks bad. |
|
Does the version of the Android Browser for Android Gingerbread fall under "old WebKit"? |
|
@cvrebert CanIUse says no. |
|
@zdroid What the right way to send a PR |
|
@awebdeveloper We'd prefer one commit containing all the changes in this PR. Try squashing your commits into a single one locally (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) and then push the changes to update this PR automatically. |
|
@awebdeveloper @juthilo Look at http://zdroid.roon.io/rebases-and-fails.
That's it. |
|
If all else fails, close this and open a new pull request. |
|
Yup. :) |
|
So you guys want me to merge all these commits into one and submit a another PR |
|
How my brain thinks: $ git reset HEAD^6 # or 7, idk number of commits
$ git add -A
$ git commit -m "..."
$ git push -f origin masterBetter suggestion: close pull request, create topic branch and then edit code. Don't edit code on I will gladly help, if you need help. 😄 |
|
@awebdeveloper Yes, please. Single commits make it super easy to pinpoint a change and roll back if need be, or at the very least get a complete picture through Git's history. Submit a new pull request with all these changes in one commit and we'll get it in there. <3 |
|
I've taken the liberty of preparing a new PR: #11694 |
based on http://caniuse.com/#search=grad css prefix for moz and old webkit removed