Skip to content

unnecessary prefixes removed for gradients#11537

Closed
awebdeveloper wants to merge 7 commits intotwbs:masterfrom
awebdeveloper:master
Closed

unnecessary prefixes removed for gradients#11537
awebdeveloper wants to merge 7 commits intotwbs:masterfrom
awebdeveloper:master

Conversation

@awebdeveloper
Copy link
Contributor

based on http://caniuse.com/#search=grad css prefix for moz and old webkit removed

@zlatanvasovic
Copy link

What did you make with commit history? This looks bad.

@cvrebert
Copy link
Collaborator

Does the version of the Android Browser for Android Gingerbread fall under "old WebKit"?

@zlatanvasovic
Copy link

@cvrebert CanIUse says no. -webkit-linear-gradient is enough.

http://caniuse.com/#search=linear-gradient

@awebdeveloper
Copy link
Contributor Author

@zdroid What the right way to send a PR

@juthilo
Copy link
Collaborator

juthilo commented Nov 20, 2013

@awebdeveloper We'd prefer one commit containing all the changes in this PR. Try squashing your commits into a single one locally (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) and then push the changes to update this PR automatically.

@zlatanvasovic
Copy link

@awebdeveloper @juthilo Look at http://zdroid.roon.io/rebases-and-fails.

Merging two smaller commits into a bigger one is bad way to add something, but when you have many commits after that you need to use merge strategies. Problem is that them make many errors.

A better way: amend changes to last commit instead of publish many commits than squashing them. This is specifically good for pull request. Example:

$ git commit --amend -C HEAD # amend it
$ git push -f # force update

That's it.

@mdo
Copy link
Member

mdo commented Nov 30, 2013

If all else fails, close this and open a new pull request.

@zlatanvasovic
Copy link

Yup. :)

@awebdeveloper
Copy link
Contributor Author

So you guys want me to merge all these commits into one and submit a another PR

@zlatanvasovic
Copy link

How my brain thinks:

$ git reset HEAD^6 # or 7, idk number of commits
$ git add -A
$ git commit -m "..."
$ git push -f origin master

Better suggestion: close pull request, create topic branch and then edit code. Don't edit code on master, because of you'll break commit history later.

I will gladly help, if you need help. 😄

@mdo
Copy link
Member

mdo commented Nov 30, 2013

@awebdeveloper Yes, please. Single commits make it super easy to pinpoint a change and roll back if need be, or at the very least get a complete picture through Git's history.

Submit a new pull request with all these changes in one commit and we'll get it in there. <3

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 3, 2013

I've taken the liberty of preparing a new PR: #11694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants