Merged
Conversation
Member
|
Already been resolved. |
This was referenced Dec 15, 2013
Contributor
Author
Member
|
@tlindig Agreed, checking it out now. |
Merged
Member
|
Revisited and merged! |
Closed
|
Good job. 😄 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input-group-btn use nowrap. Inner btn get inline-block. In that combination, any space character between the button tags take its space. The old workaround try to fix it by using negative margin-left: -4px, but that does not work well, because it dose not depend on the font size. If you did not have a space between button tags and the left button was cropped.
I try a new solution. I set the font-size to 0, so space characters will have no size. And I set margin-left: -1px for siblings, to get 1px border.
Inner btn get set the own font-size, so it should have not negative side effects.
This will fix:
#11431
#9712