Skip to content

.transition-timing-function() Mixin#12924

Merged
mdo merged 1 commit intotwbs:masterfrom
ahmadnassri:transition-timing-function-mixin
Mar 7, 2014
Merged

.transition-timing-function() Mixin#12924
mdo merged 1 commit intotwbs:masterfrom
ahmadnassri:transition-timing-function-mixin

Conversation

@ahmadnassri
Copy link
Copy Markdown

added .transition-timing-function(@timing-function) mixin, defaults to @timing-function.

useful for customizing CSS transitions.

reference: transition-timing-function on MDN

added .transition-timing-function(@timing-function) mixin, defaults to @timing-function.
@BBosman
Copy link
Copy Markdown
Contributor

BBosman commented Mar 5, 2014

I think the plan is to deprecate a lot of those mixins with the switch to autoprefixer (#12670), so I'm not sure if adding a new one to the mix makes sense at this time.

@ahmadnassri
Copy link
Copy Markdown
Author

@BBosman I'm all for killing vendor prefixes ... and thus these mixins.

That said, for folks using bootstrap LESS files directly, we may not necessarily run through an autoprefixer task (although, I probably should) so relying on a grunt task in the main build of Bootstrap may not satisfy the need for people who are using the sources directly and generating our own CSS.

I will keep this PR open for the choice of the community whether this is useful or not, but I will also go back to my project and use an auto-prefixer as well as CSScomb because that is certainly the right way to do it.

@crimeminister
Copy link
Copy Markdown

+1

@mdo
Copy link
Copy Markdown
Member

mdo commented Mar 6, 2014

Yeah I'm torn here. Clearly the route we want to go for maintaining Bootstrap is to abandon use of the mixins. However, we still need to include them for folks who just use Less or Sass.

I guess our docs should just make that clearer when we implement autoprefixer?

@ahmadnassri
Copy link
Copy Markdown
Author

@mdo I believe the community will support the move, so long as it is clearly documented (the why and the how) of relying on autoprefixer.

again, will leave this PR open for the maintainers to decide...

mdo added a commit that referenced this pull request Mar 7, 2014
…-mixin

.transition-timing-function() Mixin
@mdo mdo merged commit c16b43d into twbs:master Mar 7, 2014
@mdo mdo added this to the v3.2.0 milestone Mar 7, 2014
@BBosman
Copy link
Copy Markdown
Contributor

BBosman commented Mar 7, 2014

Makes sense.

But is there a specific reason to call the mixin transition-timing-function instead of animation-timing-function?

To me, it would me more logical to have the name match the properties it sets.

@ahmadnassri
Copy link
Copy Markdown
Author

@BBosman you sir, are correct, the mistake is the CSS property it's setting should be transition-timing-function ... I was hasty in making a PR. sending a fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants