Skip to content

Removed outline from links when focused (cleans up the topbar Navigation menus)#179

Closed
lincolnthree wants to merge 1 commit intotwbs:masterfrom
lincolnthree:master
Closed

Removed outline from links when focused (cleans up the topbar Navigation menus)#179
lincolnthree wants to merge 1 commit intotwbs:masterfrom
lincolnthree:master

Conversation

@lincolnthree
Copy link
Copy Markdown

This prevents outlines from showing on dropdown menus when clicked. I suppose a less invasive fix could be to add an extra rule to the style for the topbar itself, but I think most people usually don't like these outlines. Just a thought.

@mdo
Copy link
Copy Markdown
Member

mdo commented Sep 9, 2011

I'd rather not remove this. Huge accessibility concerns with pulling all :focus states from your sites and apps. Is this purely cosmetic or does it cause problems elsewhere? I see no outlines on the topbar links on click, only tab, which makes sense to me.

@lincolnthree
Copy link
Copy Markdown
Author

In firefox 6.0.2 on mac osx, clicking the topbar dropdown-toggle causes the
link to focus. I resolved this by switching to hover menus, but yea, I see
your point re accessibility.

Lincoln Baxter's Droid
http://ocpsoft.com
"Keep it Simple"
On Sep 9, 2011 2:23 AM, "Mark Otto" <
reply@reply.github.com>
wrote:

I'd rather not remove this. Huge accessibility concerns with pulling all
:focus states from your sites and apps. Is this purely cosmetic or does it
cause problems elsewhere? I see no outlines on the topbar links on click,
only tab, which makes sense to me.

Reply to this email directly or view it on GitHub:
#179 (comment)

@mdo mdo closed this Sep 9, 2011
@amnesia7
Copy link
Copy Markdown

amnesia7 commented Aug 3, 2012

Maybe you apply .blur(); to the javascript used for tabs so that once the necessary click or keypress event has run it removes focus from the tab link?

This would leave the outline css in place for accessibility whilst still removing the dotted line from clicked tabs for design niceness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants