Skip to content

Fix button order#183

Closed
nikku wants to merge 1 commit intotwbs:1.3-wipfrom
nikku:181-button-order
Closed

Fix button order#183
nikku wants to merge 1 commit intotwbs:1.3-wipfrom
nikku:181-button-order

Conversation

@nikku
Copy link
Copy Markdown

@nikku nikku commented Sep 9, 2011

Fix for issue #181.

@mdo
Copy link
Copy Markdown
Member

mdo commented Sep 9, 2011

Please recompile the LESS files whenever you do a pull request :).

@nikku
Copy link
Copy Markdown
Author

nikku commented Sep 9, 2011

Won't work at the moment, am using windows :o)

@mdo
Copy link
Copy Markdown
Member

mdo commented Sep 9, 2011

Gotcha. I can just manually added this change over then. Thanks!

The only nuance to this however is that any secondary buttons must come first given the new style. You're aware of that change, yes?

@vreon
Copy link
Copy Markdown

vreon commented Sep 9, 2011

Hmm, I have to say I prefer the current behavior, with the primary button being rightmost and first in the tab order. It seems that different OSes have different conventions regarding this.

@mdo
Copy link
Copy Markdown
Member

mdo commented Sep 12, 2011

Yup, going to leave them as is with floats. This way, if styles are turned off or if you wish to change them as a developer, the markup does not need to change. The primary button should come first in the markup and the CSS should change the order if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants