Add new extra large size (.modal-xl) for .modal-dialog#19925
Add new extra large size (.modal-xl) for .modal-dialog#19925malkomich wants to merge 2 commits intotwbs:v4-devfrom malkomich:v4-dev
Conversation
cvrebert
changed the title
There was a problem hiding this comment.
Missing another button for this around line 187
|
You also need to update line 184 to reflect the addition of your new size. Currently it says "Modals have two optional sizes". |
|
Why add another one? |
|
@mdo Because it was useful for me to display large tables and forms in a modal container, so I guess someone could enjoy this small enhancement. And also it doesn't break anything..so why not? 😄 |
|
This is nice to have option. |
|
actully i'm working with some modals now and was thinking i should increase the size. |
|
is this issue dead? |
| @@ -140,3 +140,7 @@ | |||
| @include media-breakpoint-up(lg) { | |||
| .modal-lg { max-width: $modal-lg; } | |||
There was a problem hiding this comment.
Maybe we can add a line below to here for smooth transition between md and lg break points.
.modal-xl { max-width: $modal-lg; }
|
This is so small and non-disruptive enhancement, guess is taken to long to get aproved the PR |
ghost
mentioned this pull request
|
Update based on this PR coming in #26821. |
8 participants
No description provided.