Remove extra media queries for setting gutters#21128
Closed
yordis wants to merge 1 commit intotwbs:v4-devfrom
yordis:remove-extra-gutter-breakpoints
Closed
Remove extra media queries for setting gutters#21128yordis wants to merge 1 commit intotwbs:v4-devfrom yordis:remove-extra-gutter-breakpoints
yordis wants to merge 1 commit intotwbs:v4-devfrom
yordis:remove-extra-gutter-breakpoints
Conversation
yordis
changed the title
cvrebert
changed the title
Author
|
@mdo if I remove my repo the PR goes away? |
Member
|
No longer relevant with #22940. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we use
media-breakpoint-upfor setup the gutters we could validate if the previous gutter is the same of the current one don't add any media query.I am wondering how many rules we could remove following the same concept 🤔 Every time we use
media-breakpoint-upbased on some map configuration we could validate the previous one likemake-container-max-widthsas well