Dropdown: refine handling of keydown in input and textarea#21802
Closed
pvdlg wants to merge 8 commits intotwbs:v4-devfrom
Closed
Dropdown: refine handling of keydown in input and textarea#21802pvdlg wants to merge 8 commits intotwbs:v4-devfrom
pvdlg wants to merge 8 commits intotwbs:v4-devfrom
Conversation
Member
|
Can you update your branch @vanduynslagerp ? Thank you 👍 |
Johann-S
requested changes
Apr 29, 2017
Member
There was a problem hiding this comment.
Your unit test failed because of the lack of .dropdown-item and li isn't focusable without tabindex="1"
With this HTML everything is fine :
<ul class="tabs">
<li class="dropdown">
<input type="text" id="input" data-toggle="dropdown">
<ul class="dropdown-menu" role="menu">
<li id="item1" tabindex="1" class="dropdown-item"><a href="#">Secondary link</a></li>
<li id="item2" tabindex="1" class="dropdown-item"><a href="#">Something else here</a></li>
<li class="divider"/>
<li tabindex="1" class="dropdown-item"><a href="#">Another link</a></li>
</ul>
</li>
</ul>
Member
|
@Johann-S I pushed the class name change but tests are still failing. Any chance you could take a look? |
Member
|
Superseded by : #24557 |
XhmikosR
reviewed
Oct 26, 2017
| // - And not a key in REGEXP_KEYDOWN => not a dropdown command | ||
| // If input/textarea: | ||
| // - If space key => not a dropdown command | ||
| // - If key is other than excape |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21366
This PR handle better the key inputs in
inputandtextareawithindropdownanddropdown-menu.As a side note, keyboard navigation is current broken and the fix is here #21535.
This PR will be fully working only when #21535 lands.
Here is the new behaviors.
inputandtextareawithin adropdown-menu:inputortextarea)inputortextareainputortextareainputortextareainputandtextareawithin adropdownbut outside of thedropdown-menu:dropdown-itemin the menudropdown-itemin the menuinputortextareainputortextarea