added icon in form validation in #22762#23312
added icon in form validation in #22762#23312chiraggmodi wants to merge 7 commits intotwbs:v4-devfrom
Conversation
|
|
||
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
| &.is-#{$state} { | ||
| ~ .custom-control-indicator { | ||
| background-color: rgba($color, .25); | ||
| background-color: rgba($color, 0.25); |
There was a problem hiding this comment.
0.25 should be written without a leading zero as .25
| } | ||
|
|
||
| // Validation icon top for textarea | ||
| textarea.form-control, |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
|
|
||
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
|
|
||
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
| &.is-#{$state} { | ||
| ~ .custom-control-indicator { | ||
| background-color: rgba($color, .25); | ||
| background-color: rgba($color, 0.25); |
There was a problem hiding this comment.
0.25 should be written without a leading zero as .25
| } | ||
|
|
||
| // Validation icon top for textarea | ||
| textarea.form-control, |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
There was a problem hiding this comment.
can any one please guide me on this issue?
There was a problem hiding this comment.
Doesn't this work?
element {
&.class {
}
}EDIT: nah, it would still complain.
There was a problem hiding this comment.
|
|
||
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
|
can any one let me know what is the right way for this Avoid qualifying class selectors with an element. validation issue? |
|
|
||
| // Validation icon top for textarea | ||
| textarea { | ||
| &.form-control, |
|
|
||
| // Validation icon top for textarea | ||
| textarea { | ||
| &.form-control, |
| background-image: $form-icon-success; | ||
| } | ||
|
|
||
| @if $state == "invalid" { |
| background-image: $form-icon-success; | ||
| } | ||
|
|
||
| @else if $state == "invalid" { |
There was a problem hiding this comment.
@else should be placed on same line as previous curly brace
|
@mdo: what do we do with this? I think we better drop this from a quick look... |
|
New PR at #26824. |
6 participants
added form validation icon mention in #22762