Skip to content

Remove jQuery from Util.js#23565

Closed
Johann-S wants to merge 2 commits intov4-devfrom
v4-util-without-jquery
Closed

Remove jQuery from Util.js#23565
Johann-S wants to merge 2 commits intov4-devfrom
v4-util-without-jquery

Conversation

@Johann-S
Copy link
Copy Markdown
Member

That's the first try to remove jQuery from our source, with this PR no more jQuery in Util.js and other plugins will follow the move 😄

I added a new folder dom which will allow us to make some usefull functions to replace jQuery

Comment thread js/src/util.js Outdated
const Util = {

TRANSITION_END: 'bsTransitionEnd',
TRANSITION_END: transition.end,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change here, before that modification folks was able to listen to bsTransitionEnd event
Now they have to listen to their browser transition end event for example : webkitTransitionEnd

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See why I insisted on doing this after v4? :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll find a solution 😉
and that's better to do it now instead of when we will have a stable release because we're still in beta so breaking change can happen and must happen now

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree... No breaking change should happen from now until v4 stable IMO.

@Johann-S Johann-S force-pushed the v4-util-without-jquery branch 2 times, most recently from d51ac3d to f9abf33 Compare August 20, 2017 18:02
@Johann-S Johann-S force-pushed the v4-util-without-jquery branch from fc2c24b to e5a0138 Compare August 21, 2017 06:08
@Johann-S
Copy link
Copy Markdown
Member Author

Close because I'll open a huge PR to track the removal of jQuery

@Johann-S Johann-S closed this Aug 21, 2017
@XhmikosR
Copy link
Copy Markdown
Member

@Johann-S: just make PRs against a new branch not v4-dev.

@Johann-S Johann-S deleted the v4-util-without-jquery branch August 21, 2017 06:24
@Johann-S Johann-S mentioned this pull request Aug 23, 2017
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants