-
-
Notifications
You must be signed in to change notification settings - Fork 79k
Removing jQuery from Alert #23596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Removing jQuery from Alert #23596
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2985fb6
Near the end of removing jQuery from Alert
Johann-S 2a5a34d
fix unit test
Johann-S 96e025c
better polyfill for closest and matches functions
Johann-S 9b65b23
Add CustomEvent polyfill and a working preventDefault for IE
Johann-S 438f06b
Add namespaced events
Johann-S 48dbae6
Add event delegation + fix EventHandler.one
Johann-S f862b8e
Remove jQuery from alert.js and add .alert only if jQuery is available
Johann-S File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /** | ||
| * -------------------------------------------------------------------------- | ||
| * Bootstrap (v4.0.0-beta): dom/data.js | ||
| * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE) | ||
| * -------------------------------------------------------------------------- | ||
| */ | ||
|
|
||
| const mapData = (() => { | ||
| const storeData = {} | ||
| return { | ||
| set(element, key, data) { | ||
| let id | ||
| if (element.key === undefined) { | ||
| element.key = { | ||
| key, | ||
| id | ||
| } | ||
| } | ||
|
|
||
| storeData[id] = data | ||
| }, | ||
| get(element, key) { | ||
| if (element.key === undefined || element.key !== key) { | ||
| return null | ||
| } | ||
| const keyProperties = element.key | ||
| return storeData[keyProperties.id] | ||
| }, | ||
| delete(element, key) { | ||
| if (element.key === undefined || element.key !== key) { | ||
| return | ||
| } | ||
| const keyProperties = element.key | ||
| delete storeData[keyProperties.id] | ||
| } | ||
| } | ||
| })() | ||
|
|
||
| const Data = { | ||
| setData(instance, key, data) { | ||
| mapData.set(instance, key, data) | ||
| }, | ||
| getData(instance, key) { | ||
| mapData.get(instance, key) | ||
| }, | ||
| removeData(instance, key) { | ||
| mapData.delete(instance, key) | ||
| } | ||
| } | ||
|
|
||
| export default Data |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how this still works.
eachis jQuery specific, isn't it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but this method is called only when jQuery is present