button: Convert to vanilla JS#23600
Merged
Johann-S merged 5 commits intov4-without-jqueryfrom Sep 1, 2017
Merged
Conversation
Member
|
it seems your tests failed because phantomsJS don't know |
Johann-S
force-pushed
the
v4-without-jquery
branch
from
b6f70b2 to
8f63c2e
Compare
Member
|
|
Johann-S
force-pushed
the
v4-without-jquery
branch
2 times, most recently
from
53f5fc0 to
5bb63b4
Compare
XhmikosR
force-pushed
the
v4-without-jquery-buttons
branch
2 times, most recently
from
42fb3e3 to
666e7a5
Compare
Johann-S
reviewed
Aug 26, 2017
Member
There was a problem hiding this comment.
Nice change 👍 I did the same but without the default value and your change is much better 😄
Member
|
Can you update our button visual test ? |
XhmikosR
force-pushed
the
v4-without-jquery-buttons
branch
6 times, most recently
from
336def2 to
b7e89bc
Compare
XhmikosR
changed the title
XhmikosR
force-pushed
the
v4-without-jquery-buttons
branch
from
b7e89bc to
1ef0d69
Compare
XhmikosR
changed the title
Johann-S
force-pushed
the
v4-without-jquery-buttons
branch
from
88887e8 to
6bf7669
Compare
XhmikosR
commented
Aug 26, 2017
|
|
||
| EventHandler.on(document, | ||
| Event.FOCUS_BLUR_DATA_API, Selector.DATA_TOGGLE_CARROT, (event) => { | ||
| const button = SelectorEngine.closest(event.target, Selector.BUTTON)[0] |
Member
Author
There was a problem hiding this comment.
@Johann-S: this [0] indeed doesn't seem right.
Johann-S
force-pushed
the
v4-without-jquery-buttons
branch
2 times, most recently
from
df0ba44 to
b3c494a
Compare
Johann-S
force-pushed
the
v4-without-jquery
branch
from
a6ddeb2 to
cbe1f0c
Compare
IE doesn't support it so just refactor our code instead of adding a polyfill.
Johann-S
force-pushed
the
v4-without-jquery-buttons
branch
from
b3c494a to
2f57725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks: