Removing jQuery from Carousel#23658
Conversation
219f4cf to
caf1d50
Compare
| } | ||
| }, | ||
|
|
||
| extend(obj1, obj2) { |
There was a problem hiding this comment.
Why not use Object.assign?
I thing another issue is that this implementation is deepCopy but $.extend by default is not recursive.
There was a problem hiding this comment.
If Object.assign cannot be used I would use arguments (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments) and then you can change Util.extend(Utils.extend... to Util.extend(obj1, obj2, obj3, ...)
There was a problem hiding this comment.
I didn't had time to think more of this implementation of extend but it did the job 😄
I'll take a look thanks @wojtask9 👍
If you want you can submit a PR which target this branch (v4-carousel-without-jquery) with a better implementation
6a60409 to
2533d79
Compare
a6ddeb2 to
cbe1f0c
Compare
8afec53 to
540e2c7
Compare
540e2c7 to
579a6f7
Compare
|
last issue here, when I call |
626b0f7 to
dce1cb3
Compare
|
I should improve my EventHandler.off(element, 'click')
// Currently
EventHandler.off(element, 'bs.carousel')
EventHandler.off(element, 'click', myHandler) |
dce1cb3 to
ce87c76
Compare
|
All test passed except one from our Button plugin but it's a known issue |
Rewrite our Carousel plugin without jQuery
Improveoffmethod of our EventHandler to remove listeners in an entire namespaceWork in progress...