Skip to content

Fixes color of popover arrow on bottom popovers#23762

Closed
andresgalante wants to merge 1 commit intotwbs:v4-devfrom
andresgalante:popover-bottom-arrow-color
Closed

Fixes color of popover arrow on bottom popovers#23762
andresgalante wants to merge 1 commit intotwbs:v4-devfrom
andresgalante:popover-bottom-arrow-color

Conversation

@andresgalante
Copy link
Copy Markdown
Collaborator

There is a bug on popovers, the arrow on the bottom pop overs is white:

screen shot 2017-08-30 at 9 37 42 pm

I've changed it to header grey:
screen shot 2017-08-30 at 9 37 36 pm

What do you think?

@wojtask9
Copy link
Copy Markdown
Contributor

this is not right fix.
You assume that .popover always have .popover-header.

I had the same problem. My fix #23110

You also mentioned that you are working on rems in popover. Maybe my PR will help a little bit because right now in BS computations for .arrow assumes that border is always 1px width/height

@andresgalante
Copy link
Copy Markdown
Collaborator Author

@wojtask9 thanks for spotting that usecase, You are absolutely right. I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants