Add text-underline Utility class, closing #23880#23881
Closed
PascaleBeier wants to merge 10 commits intotwbs:v4-devfrom
PascaleBeier:feature/text-underline
Closed
Add text-underline Utility class, closing #23880#23881PascaleBeier wants to merge 10 commits intotwbs:v4-devfrom PascaleBeier:feature/text-underline
PascaleBeier wants to merge 10 commits intotwbs:v4-devfrom
PascaleBeier:feature/text-underline
Conversation
Collaborator
|
sorry @PascaleBeier but I wouldn't like to see this merged. We need to take really good care about not turning utility classes a 1:1 reflection of every CSS property. |
Author
|
@andresgalante I guess one had to decide where to draw the line right? Interesting to see. |
Member
|
Agreed with @andresgalante but it's @mdo who will have the final word |
Member
|
I don't see us adding this one, but I would consider a |
swrobel
added a commit
to swrobel/bootstrap
that referenced
this pull request
Mar 24, 2018
mdo
pushed a commit
that referenced
this pull request
Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a Decoration block for utilites and adding .text-underline
Can be used to add the other text-decoration utilties.