Skip to content

v4 collapse without jquery#23958

Merged
Johann-S merged 2 commits intov4-without-jqueryfrom
v4-collapse-without-jquery
Sep 20, 2017
Merged

v4 collapse without jquery#23958
Johann-S merged 2 commits intov4-without-jqueryfrom
v4-collapse-without-jquery

Conversation

@Johann-S
Copy link
Copy Markdown
Member

@Johann-S Johann-S commented Sep 15, 2017

Work in progress...

@Johann-S Johann-S requested a review from XhmikosR September 15, 2017 11:15
@Johann-S Johann-S mentioned this pull request Sep 15, 2017
45 tasks
Comment thread js/src/collapse.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can comma separate the selectors. Same goes for add BTW.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, all right. Freaking IE.

@Johann-S Johann-S force-pushed the v4-collapse-without-jquery branch 3 times, most recently from 7fe7a58 to f1ba847 Compare September 15, 2017 19:29
@Johann-S Johann-S force-pushed the v4-collapse-without-jquery branch 3 times, most recently from 963e608 to 86c90cc Compare September 19, 2017 19:50
@Johann-S
Copy link
Copy Markdown
Member Author

Done 👍 waiting for #23989 before I can merge this one
if you have time @XhmikosR do not hesitate to take a look at this PR, thanks 👍

@Johann-S Johann-S force-pushed the v4-collapse-without-jquery branch from 86c90cc to 0e14735 Compare September 20, 2017 10:03
@Johann-S Johann-S merged commit bffd076 into v4-without-jquery Sep 20, 2017
@Johann-S Johann-S deleted the v4-collapse-without-jquery branch September 20, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants