Skip to content

Fix delegated event handler registration/removal#24487

Closed
alekitto wants to merge 0 commit intotwbs:v4-without-jqueryfrom
alekitto:v4-without-jquery
Closed

Fix delegated event handler registration/removal#24487
alekitto wants to merge 0 commit intotwbs:v4-without-jqueryfrom
alekitto:v4-without-jquery

Conversation

@alekitto
Copy link
Copy Markdown
Contributor

Registering the same event handler for different delegated selectors was impossible due to a bug in the event handler addHandler function. Now is correctly handled.

See #24099 (comment)

@XhmikosR
Copy link
Copy Markdown
Member

For a moment there I was like, "wtf, how did our JS grow up so much in a PR?" Then I noticed this PR targets the no jquery branch :)

@Johann-S
Copy link
Copy Markdown
Member

That's happen @XhmikosR 👍😂

Thank you @alekitto but I have already fixed that issue here
f3e6cd8
But I'll cherry pick your unit test thank you 👍

@Johann-S Johann-S closed this Oct 21, 2017
@Johann-S Johann-S reopened this Nov 1, 2017
@Johann-S
Copy link
Copy Markdown
Member

Johann-S commented Nov 1, 2017

Can you update your branch @alekitto please ?

@Johann-S Johann-S closed this Nov 1, 2017
@Johann-S
Copy link
Copy Markdown
Member

Johann-S commented Nov 1, 2017

I added your commit to v4-without-jquery thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants