Skip to content

fix vertical input button group margin#24498

Merged
mdo merged 4 commits intotwbs:v4-devfrom
gijsbotje:vertical-button-group
Oct 22, 2017
Merged

fix vertical input button group margin#24498
mdo merged 4 commits intotwbs:v4-devfrom
gijsbotje:vertical-button-group

Conversation

@gijsbotje
Copy link
Copy Markdown
Contributor

the label in a checkbox and radio version of a button group still has margins on the bottom
this breaks the vertical version of a button group and does not match the button group styling with normal buttons

fixes: #24496

@mdo mdo merged commit 2564931 into twbs:v4-dev Oct 22, 2017
@mdo mdo mentioned this pull request Oct 22, 2017
@printercu
Copy link
Copy Markdown

@gijsbotje @mdo should this be changed to use .btn-group scope instead of [data-toggle="buttons"]? This way it'll work without js behaviour too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants