Skip to content

Add Util.jQuery which will detect jQuery instead of relying on global $#24513

Merged
XhmikosR merged 2 commits intov4-devfrom
v4-dev-johann-jquery-detection
Oct 23, 2017
Merged

Add Util.jQuery which will detect jQuery instead of relying on global $#24513
XhmikosR merged 2 commits intov4-devfrom
v4-dev-johann-jquery-detection

Conversation

@Johann-S
Copy link
Copy Markdown
Member

Fixes #24500

Comment thread js/src/util.js Outdated
},

get jQuery() {
return window.$ || window.jQuery
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change the order since jQuery should always be available?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 😉

@Johann-S Johann-S force-pushed the v4-dev-johann-jquery-detection branch from 9df7d45 to c4bd869 Compare October 23, 2017 07:23
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as tests pass.

@XhmikosR XhmikosR merged commit 1487c3a into v4-dev Oct 23, 2017
@XhmikosR XhmikosR deleted the v4-dev-johann-jquery-detection branch October 23, 2017 07:35
@mdo mdo mentioned this pull request Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants