Skip to content

Ensure our plugins can work in jQuery.noConflict mode#24530

Merged
Johann-S merged 1 commit intov4-devfrom
v4-dev-johann-noconflict
Oct 24, 2017
Merged

Ensure our plugins can work in jQuery.noConflict mode#24530
Johann-S merged 1 commit intov4-devfrom
v4-dev-johann-noconflict

Conversation

@Johann-S
Copy link
Copy Markdown
Member

@Johann-S Johann-S commented Oct 24, 2017

Fixes : #24527

@nextgenthemes can you confirm it works as wanted ?
See my CodePen which use my last changes and jQuery used by Wordpress : https://codepen.io/Johann-S/pen/PJvrgj

@Johann-S Johann-S requested a review from XhmikosR October 24, 2017 08:23
@Johann-S Johann-S force-pushed the v4-dev-johann-noconflict branch from 135371e to eb37c1d Compare October 24, 2017 09:16
@nextgenthemes
Copy link
Copy Markdown
Contributor

nextgenthemes commented Oct 24, 2017

Thanks, this finally did it! Tested it here.

It would be helpful if fresh changes like this on separate branches would be build to the dist/ dir. Then people could use rawgit to include those versions onto their JSbins codepens ... (JSBin even refuses "to big" if I not use the minified version). Also the need to copy paste them is probably error prone and there is no clear indication what version is used exactly (on the Bins).

I guess you do not do this because thats not wanted in the PRs and you only build when the next version is ready? Maybe some automation for this? Just a Idea.

@Johann-S
Copy link
Copy Markdown
Member Author

Johann-S commented Oct 24, 2017

When they are a lot of changes @mdo do a build commit and it happens several times before our next release 👍

@Johann-S Johann-S force-pushed the v4-dev-johann-noconflict branch from eb37c1d to 98dda9e Compare October 24, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants