Ensure our plugins can work in jQuery.noConflict mode#24530
Merged
Conversation
135371e to
eb37c1d
Compare
Contributor
|
Thanks, this finally did it! Tested it here. It would be helpful if fresh changes like this on separate branches would be build to the I guess you do not do this because thats not wanted in the PRs and you only build when the next version is ready? Maybe some automation for this? Just a Idea. |
Member
Author
|
When they are a lot of changes @mdo do a |
eb37c1d to
98dda9e
Compare
XhmikosR
approved these changes
Oct 24, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #24527
@nextgenthemes can you confirm it works as wanted ?
See my CodePen which use my last changes and jQuery used by Wordpress : https://codepen.io/Johann-S/pen/PJvrgj