Conversation
XhmikosR
approved these changes
Oct 25, 2017
Member
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
LGTM. How about testing all of our util functions?
Johann-S
force-pushed
the
v4-dev-johann-unit-util
branch
from
bd459d6 to
c953a25
Compare
Member
Author
|
I added more unit tests, the other methods are not very relevant (reflow which just return the element's offsetHeight, supportTransitionEnd always false on QUnit and triggerTransitionEnd which just trigger an event) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Util.js is wild used in our plugins so we should be sure if it works as expected or not