Skip to content

Revisit vnu-jar suppressions and fix the script to work on 32-bit OS#24606

Merged
XhmikosR merged 9 commits intov4-devfrom
v4-dev-xmr-vnu
Oct 31, 2017
Merged

Revisit vnu-jar suppressions and fix the script to work on 32-bit OS#24606
XhmikosR merged 9 commits intov4-devfrom
v4-dev-xmr-vnu

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

Opening this so that we can tackle any redundant suppressions, with @patrickhlauke

Comment thread js/tests/visual/tooltip.html Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG is present because it's a visual unit test

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is what I had told you the other day... we need to make this work properly and not on the circle element.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but by doing that we remove a unit test previously added since a long time

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is why I say, we need to make sure things work with valid stuff and not invalid, random code...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue to track that please ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the git log and the original example was added to test an invalid code from the beginning.

So, I'm not sure what to say on the issue, so feel free to make one.

@XhmikosR XhmikosR changed the title Re-enable vnu-jar's warnings and suppress the ones we don't need now. Revisit vnu-jar suppressions and fix the script to work on 32-bit OS Oct 31, 2017
@XhmikosR XhmikosR added docs and removed on-hold labels Oct 31, 2017
@mdo mdo mentioned this pull request Oct 31, 2017
@XhmikosR XhmikosR merged commit f9188de into v4-dev Oct 31, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-vnu branch October 31, 2017 19:36
@patrickhlauke
Copy link
Copy Markdown
Member

a labour of love, this. thanks @XhmikosR for patiently coaching me through this collaborative work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants