Adds underline back to btn-link on focus#24723
Merged
patrickhlauke merged 1 commit intov4-devfrom Nov 8, 2017
Merged
Conversation
Johann-S
approved these changes
Nov 8, 2017
patrickhlauke
approved these changes
Nov 8, 2017
mdo
approved these changes
Nov 8, 2017
patrickhlauke
changed the title
btn-link on focus
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During this clean up: cd22eb1 we removed the focus state indication for
btn-link. Even though links don't have an underline and btn-link should mimic links they are missing some indication of the item been focus.This PR closes #24720 and brings back the underline. Thanks @timfish