Run our unit tests on different jQuery versions by Johann-S · Pull Request #24749 · twbs/bootstrap

Johann-S · 2017-11-10T10:29:13Z

~~I added a new devDeps because phantomjs do not allow to pass parameters in URL~~
~~BTW if this PR is accepted I'll change js-test-cloud to use our server task 👍~~

Add Karma to run our unit tests on ChromeHeadless instead of PhantomJS + it's allow us to run our unit tests on two jQuery versions

Fixes: #24705

XhmikosR · 2017-11-10T10:53:44Z

Not sure this makes sense in this branch since we already need Ruby.

I did this in my Hugo branch because the Ruby dep is removed.

OK, now I read you comment about phantom.

Why do we need phantom anyway? Can't we use jsdom or Chrome/Firefox headless?

Yep that's a possible switch because phantomjs won't receive any fixes

XhmikosR · 2017-11-10T10:56:05Z

Maybe we don't need this new file at all? It's a small snippet so perhaps we could have it in the HTML file?

yep sure 👍

XhmikosR · 2017-11-10T10:58:30Z

IMO you should revert the http-server switch here; it doesn't make things better since we already need Ruby for Jekyll.

Also, the js-tests will probably need to be run sequentially; we can't use the same port simultaneously.

Johann-S · 2017-11-10T10:59:45Z

My main issue here is how to launch a npm task in background and lauch our qunit tests 😟

Johann-S · 2017-11-10T14:21:40Z

I added Karma to run our test on ChromeHeadless it's possible to add FirefoxHeadless too so if it's wanted do not hesitate 👍

With this implementation we can run our unit tests on jQuery 1.9.1 and the latest release of jQuery 3

Johann-S · 2017-11-10T14:53:54Z

    },
    afterEach: function () {
+      $('.modal-backdrop, #modal-test').remove()
+      $(document.body).removeClass('modal-open')


I added that because in our index.html which run our unit test we did the same see : https://github.com/twbs/bootstrap/blob/v4-dev/js/tests/index.html#L82

But do we need to do it in modal.js if we do it in index.html?

Karma do not use our index.html it generate a new index.html

XhmikosR · 2017-11-16T12:57:26Z

-      jQueryVersion,
+      jqueryFile,
      'assets/js/vendor/popper.min.js',
      'js/dist/util.js',


Would it work if we did js/dist*.js and just excluded index.js? Or even just include everything?

Nope because we have to be sure util.js is the first included script

Johann-S · 2017-11-16T13:23:47Z

I made a test using jsdom and it's not possible because jsdom do not have document.createRange function which is used in Popper.js

Johann-S · 2017-11-16T14:15:59Z

@XhmikosR I changed the reporter, and now we use wildcard to include our dist files and added Firefox launcher

XhmikosR · 2017-11-16T16:16:11Z

@@ -0,0 +1,39 @@
+module.exports = function (config) {
+  const jqueryFile = process.env.USE_OLD_JQUERY === 'true' ? 'js/tests/vendor/jquery-1.9.1.min.js' : 'assets/js/vendor/jquery-slim.min.js'


Maybe process.env.USE_OLD_JQUERY would be enough?

I don't understand what you mean here 😟

I was wondering, wouldn't this be enough?

const jqueryFile = process.env.USE_OLD_JQUERY ? 'js/tests/vendor/jquery-1.9.1.min.js' : 'assets/js/vendor/jquery-slim.min.js'

Oh, and perhaps we should only change the filename and keep the path since it's common?

Johann-S · 2017-11-17T09:13:39Z

Do you have any concerns about that PR @mdo ? Or can we merge ?

FezVrasta · 2017-11-18T14:34:40Z

About Popper.js on jsdom, the suggested way is to mock Popper.js away directly since it can't work on a jsdom environment even if you polyfill everything that's required.

Johann-S · 2017-11-19T12:52:35Z

Seems better in parallel @XhmikosR 👍

Johann-S added meta v4 labels Nov 10, 2017

Johann-S requested review from XhmikosR, bardiharborow and mdo November 10, 2017 10:29

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch from bd57641 to e6c6914 Compare November 10, 2017 10:31

XhmikosR reviewed Nov 10, 2017

View reviewed changes

Johann-S changed the title ~~Allow us to run our unit test on differents jquery version~~ [WIP] Allow us to run our unit test on differents jquery version Nov 10, 2017

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch 2 times, most recently from b17c962 to e8d0378 Compare November 10, 2017 12:44

Johann-S commented Nov 10, 2017

View reviewed changes

XhmikosR added the on-hold label Nov 11, 2017

Johann-S changed the title ~~[WIP] Allow us to run our unit test on differents jquery version~~ Allow us to run our unit test on differents jquery version Nov 12, 2017

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch 2 times, most recently from fd23f0d to 95fdf6a Compare November 16, 2017 12:39

XhmikosR reviewed Nov 16, 2017

View reviewed changes

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch 3 times, most recently from 6bac084 to a1b850b Compare November 16, 2017 14:04

XhmikosR reviewed Nov 16, 2017

View reviewed changes

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch from 4cf67ea to 1c88c55 Compare November 16, 2017 21:42

XhmikosR changed the title ~~Allow us to run our unit test on differents jquery version~~ Run our unit tests on different jQuery versions Nov 17, 2017

XhmikosR removed the on-hold label Nov 17, 2017

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch from ecfc5a8 to 5cbf19f Compare November 17, 2017 08:29

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch from 5cbf19f to 45b5107 Compare November 17, 2017 08:45

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch from fe9f627 to 069ab73 Compare November 20, 2017 08:28

Johann-S and others added 2 commits November 21, 2017 22:01

Allow us to run our unit test on differents jquery version

06949e6

Run karma tests in parallel.

27e0129

Johann-S force-pushed the v4-dev-johann-tests-jquery-version branch from 069ab73 to 27e0129 Compare November 21, 2017 21:02

Merge branch 'v4-dev' into v4-dev-johann-tests-jquery-version

35c9bca

XhmikosR approved these changes Nov 23, 2017

View reviewed changes

XhmikosR merged commit 68ca294 into v4-dev Nov 23, 2017

XhmikosR deleted the v4-dev-johann-tests-jquery-version branch November 23, 2017 08:42

mdo mentioned this pull request Nov 23, 2017

Beta 3 ship list #24439

Closed

		@@ -0,0 +1,39 @@
		module.exports = function (config) {
		const jqueryFile = process.env.USE_OLD_JQUERY === 'true' ? 'js/tests/vendor/jquery-1.9.1.min.js' : 'assets/js/vendor/jquery-slim.min.js'

Uh oh!

Conversation

Johann-S commented Nov 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XhmikosR commented Nov 10, 2017

Uh oh!

Johann-S commented Nov 10, 2017

Uh oh!

Johann-S commented Nov 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Johann-S commented Nov 16, 2017

Uh oh!

Johann-S commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Johann-S commented Nov 17, 2017

Uh oh!

FezVrasta commented Nov 18, 2017

Uh oh!

Johann-S commented Nov 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Johann-S commented Nov 10, 2017 •

edited

Loading

Johann-S commented Nov 16, 2017 •

edited

Loading