Mixins form-control-focus and button-variant output invalid box-shadow value with shadows enabled#24821
Mixins form-control-focus and button-variant output invalid box-shadow value with shadows enabled#24821pat270 wants to merge 2 commits intotwbs:v4-devfrom
Conversation
There was a problem hiding this comment.
@pat270 good catch! The specs state:
The property accepts either the none value, which indicates no shadows, or a comma-separated list of shadows, ordered front to back.
https://drafts.csswg.org/css-backgrounds-3/#the-box-shadow
|
I merged #25070 and updated your branch to resolve a conflict—can you re-review? |
|
This LGTM, Thanks! Edit: Added a commit to retain active box-shadows on |
|
@pat270: please fix the conflicts and squash your commits. |
Mixin `form-control-focus` outputs invalid `box-shadow` value when shadows are enabled and `$input-box-shadow` or `$input-focus-box-shadow` value is set to `none` Mixin `button-variant` outputs invalid `box-shadow` value when shadows are enabled and `$btn-box-shadow` or `$btn-active-box-shadow` value is set to `none`
pat270
force-pushed
the
button-variant-form-control-focus
branch
from
3111299 to
d3ac424
Compare
|
@XhmikosR I ended up using rebase instead of merge, sorry about that! |
|
Cherry-picked ffcbdb5 into |
4 participants
When shadows are enabled and
$btn-box-shadow,$btn-active-box-shadow,$input-box-shadow, or$input-focus-box-shadowhave the valuenonethese mixins output invalid values for thebox-shadowproperty (e.g.,box-shadow: none, 0 0 0 0.2rem rgba(0, 123, 255, 0.25)).