Tab.js: do not remove fade class if there's no initial active pane#24871
Merged
Johann-S merged 1 commit intotwbs:v4-devfrom Nov 26, 2017
Merged
Tab.js: do not remove fade class if there's no initial active pane#24871Johann-S merged 1 commit intotwbs:v4-devfrom
Johann-S merged 1 commit intotwbs:v4-devfrom
Conversation
Johann-S
requested changes
Nov 26, 2017
Member
Johann-S
left a comment
Johann-S
left a comment
There was a problem hiding this comment.
LGTM after you made that change 👍
Member
There was a problem hiding this comment.
Should be changed to :
$(active).removeClass(`${ClassName.SHOW} ${ClassName.ACTIVE}`)
Johann-S
approved these changes
Nov 26, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small issue was discovered while rewriting tab js without jQuery for #24094 (discussion here):
The component does not trigger the fade effect if no active pane is present initially, subsequently removing the
fadeclass from all the tab elements.