Skip to content

Fix tab.js Problem #25384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johann-S merged 2 commits into from
Oct 29, 2018
Merged

Fix tab.js Problem #25384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b437b3
Update tab.js
dercodercom Jan 20, 2018
16bdbb6
add unit test to test tabs can be removed without throwing error
Johann-S Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class Tab {

_activate(element, container, callback) {
let activeElements
if (container.nodeName === 'UL') {
if (container && container.nodeName === 'UL') {
activeElements = $(container).find(Selector.ACTIVE_UL)
} else {
activeElements = $(container).children(Selector.ACTIVE)
Expand Down
45 changes: 45 additions & 0 deletions js/tests/unit/tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,4 +414,49 @@ $(function () {
})
.trigger($.Event('click'))
})

QUnit.test('should handle removed tabs', function (assert) {
assert.expect(1)
var done = assert.async()

var html = [
'<ul class="nav nav-tabs" role="tablist">',
' <li class="nav-item">',
' <a class="nav-link nav-tab" href="#profile" role="tab" data-toggle="tab">',
' <button class="close"><span aria-hidden="true">&times;</span></button>',
' </a>',
' </li>',
' <li class="nav-item">',
' <a id="secondNav" class="nav-link nav-tab" href="#buzz" role="tab" data-toggle="tab">',
' <button class="close"><span aria-hidden="true">&times;</span></button>',
' </a>',
' </li>',
' <li class="nav-item">',
' <a class="nav-link nav-tab" href="#references" role="tab" data-toggle="tab">',
' <button id="btnClose" class="close"><span aria-hidden="true">&times;</span></button>',
' </a>',
' </li>',
'</ul>',
'<div class="tab-content">',
' <div role="tabpanel" class="tab-pane fade show active" id="profile">test 1</div>',
' <div role="tabpanel" class="tab-pane fade" id="buzz">test 2</div>',
' <div role="tabpanel" class="tab-pane fade" id="references">test 3</div>',
'</div>'
].join('')

$(html).appendTo('#qunit-fixture')

$('#secondNav').on('shown.bs.tab', function () {
assert.strictEqual($('.nav-tab').length, 2)
done()
})

$('#btnClose').one('click', function () {
var tabId = $(this).parents('a').attr('href')
$(this).parents('li').remove()
$(tabId).remove()
$('.nav-tabs a:last').bootstrapTab('show')
})
.trigger($.Event('click'))
})
})