Skip to content

Dropdown. Skip element disabled via attribute when using keyboard navigation#25403

Merged
Johann-S merged 1 commit intotwbs:v4-devfrom
vsn4ik:v4-dev-dropdown-skip-by-disabled-attribute
Mar 26, 2018
Merged

Dropdown. Skip element disabled via attribute when using keyboard navigation#25403
Johann-S merged 1 commit intotwbs:v4-devfrom
vsn4ik:v4-dev-dropdown-skip-by-disabled-attribute

Conversation

@vsn4ik
Copy link
Copy Markdown
Contributor

@vsn4ik vsn4ik commented Jan 22, 2018

http://getbootstrap.com/docs/4.0/components/dropdowns/#menu-items

Historically dropdown menu contents had to be links, but that’s no longer the case with v4. Now you can optionally use <button> elements in your dropdowns instead of just <a>s.

Comment thread js/tests/unit/dropdown.js Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed order of tests

@lonelydawn
Copy link
Copy Markdown

Nice

@vsn4ik
Copy link
Copy Markdown
Contributor Author

vsn4ik commented Mar 21, 2018

@mdo Will it be added to the next release?

@Johann-S
Copy link
Copy Markdown
Member

Please @vsn4ik can you update your branch ? I'll try to review that asap 😉

@vsn4ik
Copy link
Copy Markdown
Contributor Author

vsn4ik commented Mar 25, 2018

@Johann-S Done!

Copy link
Copy Markdown
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Johann-S Johann-S merged commit 68db42c into twbs:v4-dev Mar 26, 2018
@mdo mdo mentioned this pull request Mar 26, 2018
@vsn4ik vsn4ik deleted the v4-dev-dropdown-skip-by-disabled-attribute branch March 26, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants