Replace img-fluid by w-100 in Carousel docs to conform with HTML example#25653
Merged
mdo merged 1 commit intotwbs:v4-devfrom Mar 3, 2018
webchopin:carousel-docs-slidesonly
Merged
Replace img-fluid by w-100 in Carousel docs to conform with HTML example#25653mdo merged 1 commit intotwbs:v4-devfrom webchopin:carousel-docs-slidesonly
mdo merged 1 commit intotwbs:v4-devfrom
webchopin:carousel-docs-slidesonly
Conversation
mdo
approved these changes
Mar 2, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the documentation part concerned: https://getbootstrap.com/docs/4.0/components/carousel/#slides-only
Before this PR, there was a mismatch, in Carousel docs - "Slides only" section, between the introduction stating that img-fluid is present and the code example with w-100 instead.
So, we use w-100 to conform with the code example and to be consistent with this commit: 0857713