Conversation
| // list of files / patterns to load in the browser | ||
| files: [ | ||
| jqueryFile, | ||
| 'js/tests/vendor/sinon.min.js', |
There was a problem hiding this comment.
Maybe should I add karma-sinon instead of adding this file 🤔
There was a problem hiding this comment.
If we can achieve the same without the manually copied dependency, then go for it 👍
There was a problem hiding this comment.
We'll still need the local file to run our unit test without Karma
There was a problem hiding this comment.
Your call. I'm not very familiar with the karma config.
Also, I don't quite get this whole change, care to elaborate a bit?
There was a problem hiding this comment.
Sure 😃 QUnit possess just a few methods compare to newer Framework of unit testing (Karma, Mocha), they are a lot of new concepts (Mocks, Spies, Stubs) which provide a better way to test our methods, because for example you can be sure a method have been called, or fake user data, or change temporary the behavior of our methods.
Johann-S
force-pushed
the
v4-johann-sinon
branch
from
b63d857 to
80379c5
Compare
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
Looks good as far as I can review this.
Johann-S
force-pushed
the
v4-johann-sinon
branch
from
80379c5 to
82e6d45
Compare
Johann-S
force-pushed
the
v4-johann-sinon
branch
from
82e6d45 to
756dd85
Compare
2 participants
Fixes: #25817
/CC @XhmikosR , @bardiharborow