remove default background-color from breadcrumb#25968
Closed
m5o wants to merge 1 commit intotwbs:v4-devfrom
Closed
remove default background-color from breadcrumb#25968m5o wants to merge 1 commit intotwbs:v4-devfrom
m5o wants to merge 1 commit intotwbs:v4-devfrom
Conversation
Contributor
m5o
commented
Mar 29, 2018
- remove default background-color from breadcrumb
- re-use contextual background classes for background styling
Member
|
Removing variables breaks backward compatibility. We'll want to leave the defaults and add docs for how to override those with utilities. Come v5, we can revisit the default styles. |
Contributor
Author
|
@mdo UIkit has a a.uk-link-reset, a.uk-link-reset:hover, .uk-link-reset a, .uk-link-reset a:hover {
color: inherit !important;
text-decoration: none !important;
} |
* remove default background-color from breadcrumb * re-use contextual background classes for background styling
58863bd to
97097a9
Compare
Member
|
Closing this out since it's stale and cannot be merged as-is into v4. Happy to revisit in v5, and to revisit the link reset in a subsequent minor release if there's a PR for it. |
m5o
added a commit
to m5o/bootstrap
that referenced
this pull request
Jul 25, 2018
* add text-reset to text utilities :link: twbs#25968 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.