Skip to content

remove default background-color from breadcrumb#25968

Closed
m5o wants to merge 1 commit intotwbs:v4-devfrom
m5o:breadcrumb-flexible-background-color
Closed

remove default background-color from breadcrumb#25968
m5o wants to merge 1 commit intotwbs:v4-devfrom
m5o:breadcrumb-flexible-background-color

Conversation

@m5o
Copy link
Copy Markdown
Contributor

@m5o m5o commented Mar 29, 2018

  • remove default background-color from breadcrumb
  • re-use contextual background classes for background styling

@mdo
Copy link
Copy Markdown
Member

mdo commented Apr 1, 2018

Removing variables breaks backward compatibility. We'll want to leave the defaults and add docs for how to override those with utilities. Come v5, we can revisit the default styles.

@m5o
Copy link
Copy Markdown
Contributor Author

m5o commented Apr 2, 2018

@mdo UIkit has a .[uk-]text-reset / .[uk-]link-reset util class which reset color and text-decoration. This would be super handy.

a.uk-link-reset, a.uk-link-reset:hover, .uk-link-reset a, .uk-link-reset a:hover {
  color: inherit !important;
  text-decoration: none !important;
}

📖 https://getuikit.com/docs/link#link-reset

@XhmikosR XhmikosR added the css label Apr 10, 2018
* remove default background-color from breadcrumb
* re-use contextual background classes for background styling
@m5o m5o force-pushed the breadcrumb-flexible-background-color branch from 58863bd to 97097a9 Compare April 10, 2018 09:41
@mdo
Copy link
Copy Markdown
Member

mdo commented Jul 7, 2018

Closing this out since it's stale and cannot be merged as-is into v4. Happy to revisit in v5, and to revisit the link reset in a subsequent minor release if there's a PR for it.

@mdo mdo closed this Jul 7, 2018
m5o added a commit to m5o/bootstrap that referenced this pull request Jul 25, 2018
* add text-reset to text utilities

:link: twbs#25968 (comment)
@m5o m5o deleted the breadcrumb-flexible-background-color branch October 11, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants