fix collapse and modal for IE which do not handle boolean in Object.keys#26275
Closed
fix collapse and modal for IE which do not handle boolean in Object.keys#26275
Conversation
841eb52 to
10f2df1
Compare
10f2df1 to
c348a42
Compare
Member
|
@Johann-S: I'm still seeing errors with IE10. I can't try IE11 so please try that too. |
Member
Author
ffc63c6 to
e7f717d
Compare
e7f717d to
284dec3
Compare
bb6ec58 to
b97e166
Compare
Member
Author
|
@XhmikosR I fixed unit test in a separate commit, for me it's all good and we should merge this PR. About EDIT: |
Member
Author
|
Ok so it doesn't work on Win 8.1 IE 11 and Win 8 IE 10... And I'm on Win 10 IE 11 but it works... |
b97e166 to
6157ec0
Compare
Member
Author
|
Superseded by: #26291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is covered that's why there are no unit tests in this PR
Fixes: #26266
/CC @XhmikosR