Skip to content

fix collapse and modal for IE which do not handle boolean in Object.keys#26275

Closed
Johann-S wants to merge 3 commits intov4-devfrom
v4-fix-collapse-ie
Closed

fix collapse and modal for IE which do not handle boolean in Object.keys#26275
Johann-S wants to merge 3 commits intov4-devfrom
v4-fix-collapse-ie

Conversation

@Johann-S
Copy link
Copy Markdown
Member

This code is covered that's why there are no unit tests in this PR

Fixes: #26266

/CC @XhmikosR

@Johann-S Johann-S requested a review from XhmikosR April 12, 2018 08:18
@Johann-S Johann-S force-pushed the v4-fix-collapse-ie branch from 841eb52 to 10f2df1 Compare April 12, 2018 09:19
@Johann-S Johann-S changed the title fix collapse for IE which do not handle boolean in Object.keys fix collapse and modal for IE which do not handle boolean in Object.keys Apr 12, 2018
@Johann-S Johann-S force-pushed the v4-fix-collapse-ie branch from 10f2df1 to c348a42 Compare April 12, 2018 09:22
@XhmikosR
Copy link
Copy Markdown
Member

@Johann-S: I'm still seeing errors with IE10. I can't try IE11 so please try that too.

jQuery.Deferred exception: Object.keys: argument is not an ObjectTypeError: Object.keys: argument is not an Object
   at _objectSpread (http://127.0.0.1:9001/dist/js/bootstrap.js:49:7)
   at _getConfig (http://127.0.0.1:9001/dist/js/bootstrap.js:2983:9)
   at Tooltip (http://127.0.0.1:9001/dist/js/bootstrap.js:2577:9)
   at Anonymous function (http://127.0.0.1:9001/dist/js/bootstrap.js:3060:13)
   at each (https://code.jquery.com/jquery-3.3.1.slim.min.js:2:2755)
   at each (https://code.jquery.com/jquery-3.3.1.slim.min.js:2:1429)
   at _jQueryInterface (http://127.0.0.1:9001/dist/js/bootstrap.js:3050:9)
   at Anonymous function (http://127.0.0.1:9001/assets/js/src/application.js:59:7)
   at each (https://code.jquery.com/jquery-3.3.1.slim.min.js:2:2755)
   at each (https://code.jquery.com/jquery-3.3.1.slim.min.js:2:1429)undefined 
SCRIPT5007: Object.keys: argument is not an Object 
jquery-3.3.1.slim.min.js, line 2 character 31232

@Johann-S
Copy link
Copy Markdown
Member Author

@XhmikosR
Copy link
Copy Markdown
Member

@Johann-S Johann-S force-pushed the v4-fix-collapse-ie branch from ffc63c6 to e7f717d Compare April 12, 2018 12:20
@Johann-S Johann-S force-pushed the v4-fix-collapse-ie branch from e7f717d to 284dec3 Compare April 12, 2018 12:23
@Johann-S Johann-S force-pushed the v4-fix-collapse-ie branch from bb6ec58 to b97e166 Compare April 12, 2018 13:01
@Johann-S
Copy link
Copy Markdown
Member Author

Johann-S commented Apr 12, 2018

@XhmikosR I fixed unit test in a separate commit, for me it's all good and we should merge this PR.

About extends warning, as you said on Slack we use it like this before so LGTM like that 👍

EDIT:
BTW it's possible to remove loose and avoid extends warning if you prefer 🤔 let me know 😉

@Johann-S
Copy link
Copy Markdown
Member Author

Ok so it doesn't work on Win 8.1 IE 11 and Win 8 IE 10... And I'm on Win 10 IE 11 but it works...

@Johann-S Johann-S force-pushed the v4-fix-collapse-ie branch from b97e166 to 6157ec0 Compare April 13, 2018 09:06
@Johann-S
Copy link
Copy Markdown
Member Author

Superseded by: #26291

@Johann-S Johann-S closed this Apr 13, 2018
@Johann-S Johann-S deleted the v4-fix-collapse-ie branch April 13, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants