Skip to content

Sync with normalize 8.0.0#26296

Merged
XhmikosR merged 5 commits intotwbs:v4-devfrom
Varunram:normalize
Nov 4, 2018
Merged

Sync with normalize 8.0.0#26296
XhmikosR merged 5 commits intotwbs:v4-devfrom
Varunram:normalize

Conversation

@Varunram
Copy link
Copy Markdown

diff credits: @client9

Fixes #26226

Comment thread scss/_reboot.scss Outdated
@XhmikosR
Copy link
Copy Markdown
Member

@Varunram: can you rebase please?

@Varunram
Copy link
Copy Markdown
Author

Thanks! Will do shortly.

@Varunram
Copy link
Copy Markdown
Author

should be good now :)

@XhmikosR
Copy link
Copy Markdown
Member

Ping @mdo @MartijnCuppens @andresgalante

@XhmikosR XhmikosR changed the title Resolve #26226: Sync with normalize 8.0.0 Sync with normalize 8.0.0 Oct 28, 2018
@MartijnCuppens
Copy link
Copy Markdown
Member

I think we can also remove this:

// Shim for "new" HTML5 structural elements to display correctly (IE10, older browsers)
// stylelint-disable-next-line selector-list-comma-newline-after
article, aside, figcaption, figure, footer, header, hgroup, main, nav, section {
display: block;
}

But keep the main, see necolas/normalize.css@004d58b#diff-bb3dde41d97f19be8ab7b4780a915d5e

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Oct 30, 2018

We still sort of support Android 4.4.

So perhaps we should add a TODO comment to remove that in v5.

@MartijnCuppens
Copy link
Copy Markdown
Member

Shall we add the TODO then?

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Nov 3, 2018

You can add it if you want @MartijnCuppens.

@XhmikosR XhmikosR requested a review from a team as a code owner November 3, 2018 19:59
@XhmikosR XhmikosR merged commit 38e9e2b into twbs:v4-dev Nov 4, 2018
@mdo mdo mentioned this pull request Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants