Improve documentation pagination accessibility#26355
Conversation
There was a problem hiding this comment.
only information on these rel="..." attributes being of some use i came across in the past related to them being used on <link rel="..." ...> elements in the <head>. e.g. https://support.google.com/webmasters/answer/1663744?hl=en
if authors want to add this to their code, cool (assuming the attributes on actual links, rather than <link...> elements, does anything). but i don't think it's necessary for our example code
There was a problem hiding this comment.
would make more sense to add aria-disabled="true" to the actual link
There was a problem hiding this comment.
as there's nothing focusable nor operable inside here, aria-disabled is mostly useless here
There was a problem hiding this comment.
would make more sense to add aria-disabled="true" to the actual link
ngyikp
force-pushed
the
improve-documentation-pagination-accessibility
branch
from
5babc0e to
944a05c
Compare
|
Feedback addressed, please take another look I added |
|
Punting on this for v4.2 since I'm unsure of its status and we're hoping to launch v4.1.3 next week for some timely quality of life improvements and bug fixes. |
|
@patrickhlauke Can you review and see if this is mergeable? |
|
(crikey, apologies for the multiple messages...was trying to combat github's hickup this morning, and thought they hadn't actually gone through) |
- Remove `.sr-only` span for previous/next page, there is already`aria-label` - Add `aria-disabled="true"` and `aria-current="page"`
XhmikosR
force-pushed
the
improve-documentation-pagination-accessibility
branch
from
944a05c to
29783e0
Compare
|
@patrickhlauke, I know this thing is quite outdated, but still :) Wouldn’t it be easier to solve by removing a single <li><a>1</a></li>
<li><a href>2</a></li>
<li><a href>3</a></li> |
5 participants
Fixes #22009:
Addrel="prev"andrel="next", also good for SEO!.sr-onlyspan for previous/next page, there is alreadyaria-labelaria-disabled="true"andaria-current="page"Also fix the active state on the Sizing section, the current page number was using the disabled look, it should be the active look instead.