Fixed Card Columns section#26587
Fixed Card Columns section#26587Vimal-Raghubir wants to merge 12 commits intotwbs:v4-devfrom Vimal-Raghubir:patch-1
Conversation
|
As you can see the card column that has the black outline is a duplicate of the card column above and the red column is the one that had to be placed into the card body like the 2 sections before it. |
|
Hi @mdo, |
|
Hi @XhmikosR , any update on this PR? |
|
Sorry I'm very busy with work, please be patient until someone has the time to look into the changes. |
andresgalante
left a comment
andresgalante
left a comment
There was a problem hiding this comment.
Hi @Vimal-Raghubir thanks for the PR, and sorry for taking us so long to get to review it.
I would like to keep more cards to show the masonry grid. Can we fix the text and keep the extra cards at the bottom of the right and middle column please?
| </div> | ||
| <div class="card text-center"> | ||
| <div class="card"> | ||
| <img class="card-img" data-src="holder.js/100px260/" alt="Card image"> |
There was a problem hiding this comment.
This should be card-img-top
| <div class="card-body"> | ||
| <h5 class="card-title">Card title</h5> | ||
| <p class="card-text">This card has supporting text below as a natural lead-in to additional content.</p> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This card has even longer content than the first to show that equal height action.</p> |
There was a problem hiding this comment.
This card is not wider, it's taller and it's not showing equal height
|
Hi @Vimal-Raghubir Thanks for the changes, I would still like to keep more cards to show the masonry grid. Can you add them please? thanks |
|
Hi Andres which cards are you referring to? |
|
Going to tackle this in another PR with fewer changes, thanks though. See #26732. |
4 participants
#26267 defines the second point listed above. #26586 clearly defines the issues addressed in this PR.